Editor: Rework update frequency dropdown #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Affected libs:
|
|
📷 Screenshots are here! |
| return 'annually' | ||
| case 'semimonthly': | ||
| return 'semimonthly' | ||
| case 'biennially': |
There was a problem hiding this comment.
maybe i am missing something but i don't really understand the purpose of this function, is it only to output the frequency as a string? + it is missing the default case returning null.
There was a problem hiding this comment.
Yes it seems useless now, maybe because you changed the way frequency code is handled. Dunno
There was a problem hiding this comment.
I didn't change anything regarding the frequency code handling, i have just allowed 2 more options to be displayed in the dropdown list.
AlitaBernachot
force-pushed
the
cs-editor1
branch
2 times, most recently
from
cc42ed1 to
b608aaf
Compare
fgravin
commented
Feb 4, 2025
There was a problem hiding this comment.
You should setup the prettier plugin in your IDE for automatic formatting.
AlitaBernachot
force-pushed
the
cs-editor1
branch
from
b608aaf to
6787f5c
Compare
- use array of possible value - add full ISO codelist to the model
only use codelist values. Fallback on custom period if present in the metadata
AlitaBernachot
force-pushed
the
cs-editor1
branch
from
0c28f97 to
41fb864
Compare
AlitaBernachot
force-pushed
the
cs-editor1
branch
from
fce7daf to
41ff2a3
Compare
AlitaBernachot
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the update frequency dropdown list to fit ISO codelist.
Technically: